Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor visualize.py #210

Merged
merged 27 commits into from
Feb 16, 2023
Merged

Refactor visualize.py #210

merged 27 commits into from
Feb 16, 2023

Conversation

Crinibus
Copy link
Owner

No description provided.

Crinibus added 27 commits January 11, 2023 22:22
@Crinibus
Create visualize_v2.py for refactoring visualize.py
e785807
@Crinibus
Lowercase all input string in function visualize_data
53293f0
@Crinibus
Move temporary file visualize_v2.py into visualize.py
0da7a4a
@Crinibus
Update function visualize_data - return after comparing products
f1b25ca
@Crinibus
Rename function get_products_with_names to get_master_products_with_n…
35d3f33 
…ames
@Crinibus
Fix getting products with categories, names and ids
e802883
@Crinibus
Update dataclass Product - add methods get_all_dates and get_all_prices
3cbf480
@Crinibus
Add logic for functions compare_products and show_all_products
a359b3b
@Crinibus
Rename function get_products to get_master_products
ce40642
@Crinibus
Add function show_products and simplify function compare_products
6031bf0
@Crinibus
Update function get_status_of_product_by_bool to be one line return
cf0f971
@Crinibus
Delete function show_master_product and use function show_products in…
8d091a8 
…stead
@Crinibus
Rename function show_all_products to show_master_products
65e5f35
@Crinibus
Add function is_master_product_up_to_date
443d685
@Crinibus
Update function compare_products to include products with categories …
d560169 
…and filter with only up to date (master) products
@Crinibus
Update function validate_arguments - add --category as one of the req…
b772a12 
…uired args when using --compare
@Crinibus
Update function show_master_products to filter only up to date if par…
059c685 
…ameter is true
@Crinibus
Move function get_master_products from visualize.py to new file get_p…
21b8116 
…roducts.py
@Crinibus
Add function group_master_products_by_category to get_products.py
1d3ecd2
@Crinibus
Revert "Add function group_master_products_by_category to get_product…
54b706d 
…s.py"

This reverts commit 1d3ecd2.
@Crinibus
Revert "Move function get_master_products from visualize.py to new fi…
5ec0848 
…le get_products.py"

This reverts commit 21b8116.
@Crinibus
Replace type hints in visualize.py of Iterator to Generator
78244f6
@Crinibus
Replace type hints Generator to Iterator
431e38d 
Fix type hint of function get_master_products_with_names - from list to Iterator
@Crinibus
Delete test function in visualize.py
9c84962
@Crinibus
Add function get_products_from_master_products
473df0b 
Update function compare_products to use function get_products_from_master_products
@Crinibus
Update function compare_products - don't convert to list for master_p…
cfb4956 
…roducts_with_categories
@Crinibus
Update use of --compare in README
8768c89
@Crinibus Crinibus marked this pull request as ready for review February 16, 2023 22:05
@Crinibus Crinibus merged commit f72ec48 into master Feb 16, 2023
@Crinibus Crinibus deleted the refactor-visualizing branch February 16, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Crinibus