Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting product name in ComputerSalgHandler #218

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Fix getting product name in ComputerSalgHandler #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scraper/domains.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def get_short_url(self) -> str:

class ComputerSalgHandler(BaseWebsiteHandler):
def _get_product_name(self) -> str:
return self.request_data.find("header", class_="product-header grid_20").hgroup.h1.text
return self.request_data.find("meta", {"name": "title"})["content"]

def _get_product_price(self) -> float:
return float(self.request_data.find("span", itemprop="price").text.strip().replace(".", "").replace(",", "."))
Expand Down