Add database #226
Merged
Add database #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To differentiate between Product and DataPoint in database and elsewhere
…y in format_to_new.py
… also get short_url
… 'get_products_by_product_codes', 'add_product' and 'add_datapoint' Renamed function 'get_product_by_product_id' to 'get_product_by_product_code'
…et_products_by_categories' and 'get_products_by_names'
…ducts' to format_to_new.py As these functions are probably going to be deleted from visualize.py later but should still be used in this file
…ce with generic 'add' and 'add_all'
…_by_categories' and 'get_products_by_names' Now correctly fetches the products, where before it didn't return Products but only boolean values because '.where' was missing
…s_by_names' and 'get_datapoints_by_product_codes'
…et_all_products_with_datapoints'
…show results for product names in one line and categories in another
…f no datapoints was found
…' to 'fuzzy_name'
Rename to 'get_section_by_name' and add parameter 'section_name' to make the method more versatile
Reflect previous changes
This comment was marked as off-topic.
This comment was marked as off-topic.
Not used anymore with the new database
…d add function 'read_json' Add function 'read_json' because Filemanager doesn't have that method anymore
That way it's easier to test and mock
Update some links and expected values
Update how to get name and price
Return if no datapoints for product
Crinibus
commented
Nov 17, 2023
Reword a sentence
…IS STORED IN V3.0.0"
…N V3.0.0" Note about overwriting data in database with contents in records.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.