Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More E2e tests, testTags, fixes (pt 3) #60

Merged
merged 10 commits into from
Aug 19, 2023
Merged

Conversation

deepanchal
Copy link
Contributor

@deepanchal deepanchal commented Aug 17, 2023

Description

Note: Please merge this PR after #59 is merged as its branched off from that PR.

  • feat(e2e): fix work-view e2e flow, use testTags for assertions, remove duplicate assertions (867fa27)
  • fix(e2e): wait for incidents to load, use testTag to open New Case popup (603dffb)
  • feat(caseeditor): add testTags on location related fields in LocationScreen (dbe6ada)
  • feat(caseeditor): add testTags for EditNoteDialog field elements (4223f46)
  • feat(caseeditor): add testTags for high priority & member of my org checkboxes (b4fd290)
  • feat(caseeditor): add testTags on PropertyNotesFlagView for notes related fields (9c99cd2)
  • feat(caseeditor): set testTag for editing notes for case in EditExistingCaseNotesView (c3d3afd)
  • feat(e2e): make major improvements to new-case-view e2e flow, use script for dynamic assertions (11660e0)
  • feat(e2e): test for more testTags on new case screen in new-case-view e2e flow (72f997f)
  • feat(e2e): add e2e flow for checking visibility of custom address fields on new case view (ffae09b)

Screenshots

N/A

Related Issue

Ref: #50, #52

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Does this introduce a breaking change?

  • Yes
  • No

@deepanchal deepanchal marked this pull request as draft August 17, 2023 21:58
@deepanchal deepanchal marked this pull request as ready for review August 18, 2023 15:10
@deepanchal deepanchal force-pushed the feat/more-e2e-tests-3 branch from 8c5548f to ffae09b Compare August 18, 2023 15:56
@deepanchal deepanchal requested a review from hueachilles August 18, 2023 15:56
@hueachilles hueachilles merged commit 4a212e4 into main Aug 19, 2023
@hueachilles
Copy link
Collaborator

Good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants