Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Clicking Max button for Swaps/Limits overestimates max amount when gas cost is high #3222

Closed
benwolski opened this issue Nov 13, 2023 · 0 comments · Fixed by #3221
Closed

[Bug]: Clicking Max button for Swaps/Limits overestimates max amount when gas cost is high #3222

benwolski opened this issue Nov 13, 2023 · 0 comments · Fixed by #3221
Labels
bug Something isn't working

Comments

@benwolski
Copy link
Collaborator

benwolski commented Nov 13, 2023 •
edited
Loading

What happened?

image

How?

wait for gas price to increase, attempt to swap/ add limit for maximum ETH balance

What was Expected?

max swap / limit amount should decrease as gas cost increases and metamask should not complain that the user's ETH wallet balance is insufficient to cover gas

Relevant log output

No response

What browser(s) are you seeing the problem on?

No response

What wallet are you seeing the problem on?

No response
@benwolski benwolski added the bug Something isn't working label Nov 13, 2023
@benwolski benwolski mentioned this issue Nov 13, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add dynamic ETH offset for swaps/limits CrocSwap/ambient-ts-app
1 participant
@benwolski