Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic ETH offset for swaps/limits #3221

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

benwolski
Copy link
Collaborator

@benwolski benwolski commented Nov 13, 2023

Describe your changes

add dynamic ETH offset for swaps/limits

Link the related issue

Closes #3222

Checklist before requesting a review

  • Is this PR ready for merge? (Please convert to a draft PR otherwise)
  • I have performed a self-review of my code.
  • Did I request feedback from a team member prior to merge?
  • Does my code following the style guide at docs/CODING-STYLE.md?

Instructions for Reviewer

Functionalities or workflows that should specifically be tested.

Environmental conditions which may result in expected but differential behavior.

If relevant, list additional work to complete pre-merge (delete logging, code abstraction, etc)

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for ambient-finance ready!

Name Link
🔨 Latest commit 9759d74
🔍 Latest deploy log https://app.netlify.com/sites/ambient-finance/deploys/6552a9facc21f6000817fcb9
😎 Deploy Preview https://deploy-preview-3221--ambient-finance.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benwolski benwolski merged commit 2870b88 into develop Nov 13, 2023
@benwolski benwolski deleted the add-dynamic-eth-offset-for-swaps-and-limits branch November 13, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Clicking Max button for Swaps/Limits overestimates max amount when gas cost is high
1 participant