Remove duplicate entries for auto-completion suggestions and sort

[martin-fleck-at]

• Prefer package local names over global names
• Sort local names before global name in textual and diagram editor

Fixes #66

[github-actions]

Unit Test Results

  3 files  ± 0   24 suites  +6   3m 3s ⏱️ +10s
 36 tests +11   36 ✅ +11  0 💤 ±0  0 ❌ ±0 
108 runs  +33  108 ✅ +33  0 💤 ±0  0 ❌ ±0 

Results for commit 84bfdb6. ± Comparison against base commit a38f61d.

♻️ This comment has been updated with latest results.

[martin-fleck-at]

@harmen-xb I'm facing an issue with Windows on this one. Maybe you could help me out here since I don't have a Windows machine to try. It must have something to do with the paths not properly recognizing that one URI is not a child of another.

[harmen-xb]

@martin-fleck-at I finally got the debugging to work (i had the same issue on linux when running a single test). It had to do with the 'outFiles' being set to an empty array apparantly.

I ran the unit tests of the uri-util class and I noticed a relavant difference in the posifxPath.relative function.

See the relative result in linux:

And on Windows:

See how in Windows the result is prefixed with ..\ i.s.o. only the child part. I have the idea the problem is in this part.

[UPDATE] I checked the uri-utils, what would happen if we only use nodePath and not the posix variant if it's available and then all tests on the uri-utils succeed on linux and on windows. Also I see the relative command working. I think this is because the unit tests only use posix paths, so there is no file:\C:\some\path as an example. It does however not solve the label issue (I can't find where the label is constructed in the code).

[harmen-xb]

@martin-fleck-at

I looked at the "Completion for entity references in project B" scemario why it fails and I noticed in Windows the itemsToString function in langium-test.js returns a different result. The object is not prefixed with the system name, while in Linux it is.

Here in Linux:

And then same scenario in Windows:

When looking at it further I see the 'Label' property in Linux is prefixed with the system name, but in Windows it's not.

[martin-fleck-at]

[UPDATE] I checked the uri-utils, what would happen if we only use nodePath and not the posix variant if it's available and then all tests on the uri-utils succeed on linux and on windows. Also I see the relative command working. I think this is because the unit tests only use posix paths, so there is no file:\C:\some\path as an example. It does however not solve the label issue (I can't find where the label is constructed in the code).

That sounds good! So if I understand you correctly, not using the posix-path yields better result and for the test URIs we should use Windows-style paths on Windows and Unix-style paths on Unix and then it should work, is that correct? I do not really remember anymore why we had to do the posix-specific behavior tbh.

[harmen-xb]

That sounds good! So if I understand you correctly, not using the posix-path yields better result and for the test URIs we should use Windows-style paths on Windows and Unix-style paths on Unix and then it should work, is that correct? I do not really remember anymore why we had to do the posix-specific behavior tbh.

The uri-utils tests do succeed on windows when you remove the usage of posix. But as I said, I think this is mainly because there is no test with a real Windows path starting with a drive. It might fail at that point, didn't have time to test this yet.

Maybe we can have a look at the code where the label of an object is constructed and debug it there. Cause on Windows it's stil not prefixed with the system node (like in Linux)..

[martin-fleck-at]

@harmen-xb The latest update made the CI happy so I think we can merge this, what do you think? Feel free to approve if you agree ;-)

[harmen-xb]

Changes look good!