Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support filtering on host online state #49

Merged
merged 10 commits into from
May 5, 2023
Merged

[FEATURE] Support filtering on host online state #49

merged 10 commits into from
May 5, 2023

Conversation

kenoel
Copy link
Collaborator

@kenoel kenoel commented May 5, 2023

Adds Filtering on Host Online State

  • Enhancement
  • Bug fixes
  • Breaking change
  • Documentation

Added features and functionality

New optional argument -o or --online_state in the host_search command to filter on online, offline, unknown. In the shell command, the number of connected hosts listed is now the number of online hosts unless queueing is enabled.

Issues resolved

Other

  • Requires Caracara version >= 0.3.0

@kenoel kenoel linked an issue May 5, 2023 that may be closed by this pull request
Suggestion - add a command that reports the connected hosts. #42
Closed
ChristopherHammond13
ChristopherHammond13 approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@ChristopherHammond13 ChristopherHammond13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! Just going to get the version number bumped in pyproject.toml, and then I'm happy to release this.

@ChristopherHammond13 ChristopherHammond13 merged commit aca26b0 into main May 5, 2023
@ChristopherHammond13 ChristopherHammond13 deleted the feature/list_connected_hosts branch May 5, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherHammond13 ChristopherHammond13 ChristopherHammond13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion - add a command that reports the connected hosts.
2 participants
@kenoel @ChristopherHammond13