Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes rule group addition in IoaRuleGroup._update_create_delete #217

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

hur
Copy link
Collaborator

@hur hur commented Oct 25, 2024

Fixes rule group addition in IoaRuleGroup._update_create_delete

  • Enhancement
  • Major feature update
  • Bug fixes
  • Breaking change
  • Updated unit tests
  • Documentation

Bandit analysis

(caracara-py3.11) redacted@redacted tests % bandit -r . -s B101
[main]	INFO	Found project level .bandit file: ./.bandit
[utils]	WARNING	Unable to parse config file ./.bandit or missing [bandit] section
[main]	INFO	profile include tests: None
[main]	INFO	profile exclude tests: None
[main]	INFO	cli include tests: None
[main]	INFO	cli exclude tests: B101
[main]	INFO	running on Python 3.11.9
Run started:2024-10-25 11:47:03.460315

Test results:
	No issues identified.

Code scanned:
	Total lines of code: 1586
	Total lines skipped (#nosec): 0

Run metrics:
	Total issues (by severity):
		Undefined: 0
		Low: 0
		Medium: 0
		High: 0
	Total issues (by confidence):
		Undefined: 0
		Low: 0
		Medium: 0
		High: 0
Files skipped (0):

Added features and functionality

Issues resolved

  • Fixes a bug in rule creation for an IoaRuleGroup which results in newly created rules not being returned back after updating a rule group

Other

  • Added a unit test to cover this case. Unfortunately required a fair bit of code duplication with the way to tests are structured right now.

@hur
Copy link
Collaborator Author

hur commented Oct 25, 2024

Missed my initial testing for #216 since new_rule existed within the scope and thus worked for the case where only one rule was added, but broke when multiple rules were added.

@hur hur self-assigned this Oct 25, 2024
@ChristopherHammond13 ChristopherHammond13 merged commit fa5d3c1 into CrowdStrike:main Oct 25, 2024
8 checks passed
@ChristopherHammond13 ChristopherHammond13 added the bug 🐛 Something isn't working label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants