Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Seek() method to Decoder #136

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

dylan-bourque
Copy link

add new Seek() method (satisfying io.Seeker) to Decoder with associated tests
also add Mode() to expose the read mode (fast vs safe) to consumers

add new `Seek()` method (satisfying `io.Seeker`) to `Decoder` with associated tests
also add `Mode()` to expose the read mode (fast vs safe) to consumers
@dylan-bourque dylan-bourque requested review from a team January 2, 2024 15:22
Copy link

@wmorgan6796 wmorgan6796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only request is that you update the PR title or body to mention the adding of the Mode() function

decoder.go Show resolved Hide resolved
@dylan-bourque dylan-bourque merged commit 627ea6a into main Jan 2, 2024
5 checks passed
@dylan-bourque dylan-bourque deleted the feat/add-decoder-seek branch January 2, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants