-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Locale Inputs, Resolving broken embroiderer dependencies, Unfocus Formatting #541
base: main
Are you sure you want to change the base?
Conversation
… and updated test app
Hotfix ts
…l number formatting
|
Hey @ErvinSabic, thanks for working on this! Just kicked off CI. Tests including Embroider are passing! 🎉 But some type errors, fyi |
Yep! Still working on it. o7 |
…k on local number input
…n multiple languages
@simonihmig I encourage you to give this a try locally. I'm going to be writing more tests for it and I want to try it on a mobile device as well to see what happens with the caret positioning. It should work for: Does not support: It is worth noting that there are edge cases with the way Intl.NumberFormat may handle some things. For example, in a Saudi Arabian Locale if you enter "2" in a input that is setup for units, and the units being liters, that locale actually has a specific word that communicates "2 liters". Just based on my testing. I imagine it's much like how an American might call "12 eggs" a "dozen eggs". Though I'm not a linguist and I don't speak arabic. I'm stopping here because if I keep chasing edge cases this will never get done and in its current form supports the majority of use cases one might expect out of a component like this. |
This seeks to solve a few issues:
#468
#483
Dependency issue mentioned by Windvis here - #540 (comment)
Will mark as ready when I believe it can be submitted for review.