Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set all form elements to w-full and adjust docs #232

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Conversation

ynotdraw
Copy link
Contributor

@ynotdraw ynotdraw commented Jul 25, 2023

🚀 Description

  • Adds w-full to all form elements
    • Went ahead and made this a breaking change (aka pre-1.0 minor update) to play it safe
  • Adjusts the changeset demo to include character counter examples with maximum lengths
  • Adjusts the changeset demo to be visually centered

🔬 How to Test

  • View doc pages and verify everything looks good, or view the images below

📸 Images/Videos of Functionality

New form layout

Screen.Recording.2023-07-25.at.8.37.17.AM.mov

Maximum length input example

Screenshot 2023-07-25 at 8 31 42 AM

Maximum length textarea example

Screenshot 2023-07-25 at 8 37 10 AM

@ynotdraw ynotdraw self-assigned this Jul 25, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

🦋 Changeset detected

Latest commit: 3d6c159

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@crowdstrike/ember-toucan-core Minor
@crowdstrike/ember-toucan-form Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

Preview URLs

Env: preview
Docs: https://c61edf25.ember-toucan-core.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants