Skip to content

Commit

Permalink
[DEPLOY] v0.6.2 - Uber class empty ids array fix (#315)
Browse files Browse the repository at this point in the history
* Fix Uber passing empty ids array. Closes #314.

* Bump version -> 0.6.2

* Update CHANGELOG.md

* Fix typo
  • Loading branch information
jshcodes authored Aug 23, 2021
1 parent 5c70b6a commit 45cce72
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Version 0.6.2
## Issues resolved
+ Bug fix: Fixed Uber class passing empty **ids** parameter array when no _ids_ had been provided to the command method. Closes #314. `_util.py`

# Version 0.6.1
## Issues resolved
+ Bug fix: Fixed bad comparison for endpoint lookups when using Service Classes. Closes #305. `_util.py`
Expand Down
3 changes: 3 additions & 0 deletions src/falconpy/_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,9 @@ def calc_url_from_args(target_url: str, passed_args: dict) -> str:
delim = "&" if "?" in target_url else "?"
target_url = f"{target_url}{delim}file_name={str(passed_args['file_name'])}"

# Bug fix: Issue #314 - Passing an empty ids array is causing a 400 in the IOC API
target_url = target_url.replace("?ids={}", "")

return target_url


Expand Down
2 changes: 1 addition & 1 deletion src/falconpy/_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
For more information, please refer to <https://unlicense.org>
"""
_VERSION = '0.6.1'
_VERSION = '0.6.2'
_MAINTAINER = 'Joshua Hiller'
_AUTHOR = 'CrowdStrike'
_AUTHOR_EMAIL = 'falconpy@crowdstrike.com'
Expand Down

0 comments on commit 45cce72

Please sign in to comment.