Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] tokens_update payload handler does not properly handle the revoked keyword argument #1074

Closed
jshcodes opened this issue Nov 15, 2023 · 0 comments · Fixed by #1079
Closed

[ BUG ] tokens_update payload handler does not properly handle the revoked keyword argument #1074

jshcodes opened this issue Nov 15, 2023 · 0 comments · Fixed by #1079
Assignees
@jshcodes
Labels
bug 🐛 Something isn't working installation tokens Installation tokens issues and questions

Comments

@jshcodes
Copy link
Member

Describe the bug
The tokens_update method within the InstallationTokens Service Class has an error in the payload handler that does not recognize when the revoked argument is passed as False.

To Reproduce
Create an instance of the InstallationTokens Service Class and call the tokens_update method with revoked set to False. This value is not properly passed to the body payload.

Expected behavior
When the revoked keyword is provided, it should be flowed down to the body payload regardless of value.

Environment (please complete the following information):

  • OS: All Supported
  • Python: All Supported
  • FalconPy: 0.7.0 - 1.3.3

Additional context
Discovered while working on an Installation Tokens sample.
@jshcodes jshcodes added the bug 🐛 Something isn't working label Nov 15, 2023
@jshcodes jshcodes self-assigned this Nov 15, 2023
jshcodes added a commit that referenced this issue Nov 15, 2023
@jshcodes
Fix body payload handler. Closes #1074.
63d151e
@jshcodes jshcodes added the installation tokens Installation tokens issues and questions label Nov 15, 2023
@jshcodes jshcodes changed the title [ BUG ] tokens_update payload handler does not properly pass handle the revoked keyword argument [ BUG ] tokens_update payload handler does not properly handle the revoked keyword argument Nov 15, 2023
jshcodes added a commit that referenced this issue Nov 18, 2023
@jshcodes
Fix body payload handler. Closes #1074.
a6d1447
@jshcodes jshcodes mentioned this issue Nov 20, 2023
Merged
5 tasks
jshcodes added a commit that referenced this issue Nov 21, 2023
@jshcodes
Fix body payload handler. Closes #1074.
76b0749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
bug 🐛 Something isn't working installation tokens Installation tokens issues and questions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 1.3.4 - Context manager support, bug fixes and operation updates CrowdStrike/falconpy
1 participant
@jshcodes