Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ DOC ] Default value for limit is incorrectly listed in documentation for the QueryDetects operation #1089

Closed
3 tasks done
dkang-firmus opened this issue Dec 12, 2023 · 2 comments · Fixed by #1092
Closed
3 tasks done

[ DOC ] Default value for limit is incorrectly listed in documentation for the QueryDetects operation #1089

dkang-firmus opened this issue Dec 12, 2023 · 2 comments · Fixed by #1092
Assignees
@jshcodes
Labels
detects Detections issues and questions documentation 📖 Improvements or additions to documentation

Comments

@dkang-firmus
Copy link

dkang-firmus commented Dec 12, 2023 •
edited by jshcodes
Loading

Documentation page topic

Describe the error or typo
In the 'limit' field, the default value is '100', not '9999'

Documentation repository:

  • GitHub Wiki
  • falconpy.io
  • Source code - docstring

Additional context
Perhaps need to change the value in swagger UI as well.
@dkang-firmus dkang-firmus added the documentation 📖 Improvements or additions to documentation label Dec 12, 2023
@jshcodes jshcodes changed the title [ DOC ] ... [ DOC ] Default value for limit is incorrectly listed in documentation for the QueryDetects operation Dec 12, 2023
@jshcodes jshcodes self-assigned this Dec 12, 2023
@jshcodes
Copy link
Member

Hi @dkang-firmus -

Thank you for reporting this, we will get these updated! 😄

@jshcodes jshcodes added the detects Detections issues and questions label Dec 12, 2023
@jshcodes
Copy link
Member

jshcodes commented Dec 13, 2023 •
edited
Loading

This issue has been resolved within the Wiki and on falconpy.io. The docstring correction will be included as part of the 1.3.5 release.

jshcodes added a commit that referenced this issue Dec 13, 2023
@jshcodes
Fix docstring typo. Closes #1089.
670e84d
@jshcodes jshcodes mentioned this issue Dec 22, 2023
Merged
4 tasks
jshcodes added a commit that referenced this issue Dec 23, 2023
@jshcodes
Fix docstring typo. Closes #1089.
4ea479a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
detects Detections issues and questions documentation 📖 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 1.3.5 - New API operations and minor fixes CrowdStrike/falconpy
2 participants
@jshcodes @dkang-firmus