Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ DOC ] Typo in docstring: FirewallManagement.create_rule_group #692

Closed
1 task done
jshcodes opened this issue Jun 15, 2022 · 0 comments · Fixed by #693
Closed
1 task done

[ DOC ] Typo in docstring: FirewallManagement.create_rule_group #692

jshcodes opened this issue Jun 15, 2022 · 0 comments · Fixed by #693
Assignees
@jshcodes
Labels
documentation 📖 Improvements or additions to documentation firewall Firewall Policies and Management issues and questions

Comments

@jshcodes
Copy link
Member

Documentation page topic
https://github.com/CrowdStrike/falconpy/blob/main/src/falconpy/firewall_management.py#L652

Describe the error or typo
Docstring incorrectly references "Local address" and "Local port" for the remote_address and remote_port keywords.

Documentation repository:

  • Source code - docstring

Additional context
Discovered during the v1.1.3 wiki content refresh.
@jshcodes jshcodes added documentation 📖 Improvements or additions to documentation firewall Firewall Policies and Management issues and questions labels Jun 15, 2022
@jshcodes jshcodes self-assigned this Jun 15, 2022
jshcodes added a commit that referenced this issue Jun 15, 2022
@jshcodes
Fix docstring typo. Closes #692.
70510c1
@jshcodes jshcodes mentioned this issue Jun 15, 2022
Merged
2 tasks
jshcodes added a commit that referenced this issue Jun 15, 2022
@jshcodes
Fix docstring typo. Closes #692.
dca1ab8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
documentation 📖 Improvements or additions to documentation firewall Firewall Policies and Management issues and questions
Projects
None yet
Milestone
No milestone
1 participant
@jshcodes