Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ DOC ] host_timeout_duration is missing from RealTimeResponse service class docstrings #774

Closed
3 tasks done
jshcodes opened this issue Sep 8, 2022 · 1 comment · Fixed by #777
Closed
3 tasks done

[ DOC ] host_timeout_duration is missing from RealTimeResponse service class docstrings #774

jshcodes opened this issue Sep 8, 2022 · 1 comment · Fixed by #777
Assignees
@jshcodes
Labels
documentation 📖 Improvements or additions to documentation RTR Real Time Response issues and questions

Comments

@jshcodes
Copy link
Member

jshcodes commented Sep 8, 2022

Documentation page topic
real_time_response.py

Describe the error or typo
The new parameter host_timeout_duration is not listed in the available keywords within operations inside the RealTimeResponse Service Class.

Add these details to the wiki page for this Service Class as well.

Documentation repository:

  • GitHub Wiki
  • falconpy.io
  • Source code - docstring

Additional context
Identified while finalizing v1.2.0 documentation.
@jshcodes jshcodes added the documentation 📖 Improvements or additions to documentation label Sep 8, 2022
@jshcodes jshcodes self-assigned this Sep 8, 2022
@jshcodes jshcodes added the RTR Real Time Response issues and questions label Sep 9, 2022
jshcodes added a commit that referenced this issue Sep 9, 2022
@jshcodes
Add host_timeout_duration docstrings. Closes #774.
fade3a7
@jshcodes jshcodes mentioned this issue Sep 9, 2022
Merged
2 tasks
@jshcodes
Copy link
Member Author

jshcodes commented Sep 9, 2022

Wiki content updated. Replicated to falconpy.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
documentation 📖 Improvements or additions to documentation RTR Real Time Response issues and questions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 1.2.1 - Minor docstring updates. Add post_device_details_v2 alias. CrowdStrike/falconpy
1 participant
@jshcodes