Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] Add missing alias for update_policy_container_v2 to the FirewallManagement Service Class #856

Closed
jshcodes opened this issue Dec 13, 2022 · 0 comments · Fixed by #860
Closed

[ BUG ] Add missing alias for update_policy_container_v2 to the FirewallManagement Service Class #856

jshcodes opened this issue Dec 13, 2022 · 0 comments · Fixed by #860
Assignees
@jshcodes
Labels
bug 🐛 Something isn't working firewall Firewall Policies and Management issues and questions

Comments

@jshcodes
Copy link
Member

Describe the bug
The new operation update_policy_container_v2 is a complete replacement for the deprecated operation, update_policy_container. The deprecated operation has been moved to update_policy_container_v1 and the new operation now is used for calls to update_policy_container. The alias for the new operation update_policy_container_v2 is missing.

To Reproduce
Create an instance of the FirewallManagement Service Class or the Uber Class and try and call the operation ID update_policy_container_v2. The call will fail.

Expected behavior
The same response that is received when the operation ID update_policy_container is called.

Environment (please complete the following information):

  • OS: All supported
  • Python: All supported
  • FalconPy: 1.2.6 only

Additional context
Discovered while updating documentation to reflect v1.2.6 changes.
@jshcodes jshcodes added bug 🐛 Something isn't working firewall Firewall Policies and Management issues and questions labels Dec 13, 2022
@jshcodes jshcodes self-assigned this Dec 13, 2022
jshcodes added a commit that referenced this issue Dec 18, 2022
@jshcodes
Add missing alias. Closes #856.
aa80870
jshcodes added a commit that referenced this issue Dec 18, 2022
@jshcodes
Add missing alias. Closes #856.
037f796
@jshcodes jshcodes mentioned this issue Dec 18, 2022
Merged
2 tasks
jshcodes added a commit that referenced this issue Dec 19, 2022
@jshcodes
Add missing alias. Closes #856.
cd30826
jlangdev pushed a commit that referenced this issue Dec 19, 2022
@jshcodes @jlangdev
Add missing alias. Closes #856.
b28651c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
bug 🐛 Something isn't working firewall Firewall Policies and Management issues and questions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 1.2.7 - Kubernetes Protection, Sample Uploads operations. Alias fixes. CrowdStrike/falconpy
1 participant
@jshcodes