Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ] GetVulnerabilities operation does not return results when called from the Uber Class using the ids keyword. #864

Closed
jshcodes opened this issue Dec 22, 2022 · 0 comments · Fixed by #865
Assignees
Labels
bug 🐛 Something isn't working intel Threat Intel issues and questions

Comments

@jshcodes
Copy link
Member

Describe the bug
If you use the Uber Class to call the new GetVulnerabilities operation, you will be returned an empty dataset if you provide IDs using the ids keyword. If you provide a body payload, this operation performs as expected.

To Reproduce
Create an instance of the Uber Class, create a list of IDs by calling QueryVulnerabilities, and then provide these IDs to the GetVulnerabilities operation using the ids keyword.

Expected behavior
You should be returned a valid dataset similar to what is produced by the Intel Service Class or when you provide IDs using the ids keyword.

Environment (please complete the following information):

  • OS: All Supported
  • Python: All supported
  • FalconPy: 1.2.6 - 1.2.7

Additional context
This is a POST operation. ids provided to the Uber Class are not being migrated over to the body payload before the API request is made.

Please note: You can work around this issue by providing a full body payload to the Uber Class using the body keyword.

Caused by this operation ID not being added to the PREFER_IDS_IN_BODY constant.

Thanks go out to @tsullivan06 for identifying this issue!

@jshcodes jshcodes added bug 🐛 Something isn't working intel Threat Intel issues and questions labels Dec 22, 2022
@jshcodes jshcodes self-assigned this Dec 22, 2022
jshcodes added a commit that referenced this issue Dec 22, 2022
jshcodes added a commit that referenced this issue Dec 22, 2022
jshcodes added a commit that referenced this issue Dec 22, 2022
jshcodes added a commit that referenced this issue Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working intel Threat Intel issues and questions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant