Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ] upload_sample method does not define a default for the file_data keyword within the FalconXSandbox Service Class #898

Closed
jshcodes opened this issue Jan 27, 2023 · 0 comments · Fixed by #903
Assignees
Labels
bug 🐛 Something isn't working Falcon Intelligence Falcon Intelligence issues and questions

Comments

@jshcodes
Copy link
Member

jshcodes commented Jan 27, 2023

Describe the bug
The upload_sample operation does not properly define the file_data keyword with a default value. Due to this, developers who make use of the sample or upfile keywords may encounter 500s when trying to upload files via this method.

To Reproduce
Create an instance of the FalconXSandbox Service Class.
Attempt to upload a file using the upload_sample operation, but use the sample or upfile keyword instead of file_data.

Expected behavior
File should upload successfully regardless of the keyword used to provide the file.

Environment (please complete the following information):

  • OS: All supported
  • Python: All supported
  • FalconPy: <= 1.2.10

Additional context
Thanks go out to @awhogan for identifying and reporting this issue! 🙇

Developers can workaround this issue by making use of the file_data keyword instead.

@jshcodes jshcodes added the bug 🐛 Something isn't working label Jan 27, 2023
@jshcodes jshcodes self-assigned this Jan 27, 2023
@jshcodes jshcodes added the Falcon Intelligence Falcon Intelligence issues and questions label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working Falcon Intelligence Falcon Intelligence issues and questions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant