Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ DOC ] combinedQueryVulnerabilities operation supports 5000 results #922

Closed
3 tasks done
cactusjuan opened this issue Feb 24, 2023 · 1 comment · Fixed by #924
Closed
3 tasks done

[ DOC ] combinedQueryVulnerabilities operation supports 5000 results #922

cactusjuan opened this issue Feb 24, 2023 · 1 comment · Fixed by #924
Assignees
@jshcodes
Labels
API usage General API usage issues and questions documentation 📖 Improvements or additions to documentation spotlight Spotlight issues and questions

Comments

@cactusjuan
Copy link

cactusjuan commented Feb 24, 2023 •
edited by jshcodes
Loading

Documentation page topic
Documentation page topic or source code module where the issue was identified.
https://www.falconpy.io/Service-Collections/Spotlight-Vulnerabilities.html#combinedqueryvulnerabilities

Describe the error or typo
A clear and concise description of where the issue occurs.
The limit states 400 is the max results it can return but in the swagger documentation, it is 5000. Tested and 5000 works

Documentation repository:

  • GitHub Wiki
  • falconpy.io
  • Source code - docstring

Additional context
Add any other context about the problem here.
@cactusjuan cactusjuan added the documentation 📖 Improvements or additions to documentation label Feb 24, 2023
@jshcodes jshcodes changed the title [ DOC ] ... [ DOC ] combinedQueryVulnerabilities operation supports 5000 results Feb 24, 2023
@jshcodes jshcodes added the spotlight Spotlight issues and questions label Feb 24, 2023
@jshcodes jshcodes self-assigned this Feb 24, 2023
@jshcodes
Copy link
Member

Confirmed new limit is accurate, updating documentation. (Thank you for pointing this out! 😄)

jshcodes added a commit that referenced this issue Feb 24, 2023
@jshcodes
Update combinedQueryVulnerabilities operation limit. Closes #922.
93745a8
@jshcodes jshcodes added the API usage General API usage issues and questions label Feb 24, 2023
jshcodes added a commit that referenced this issue Feb 25, 2023
@jshcodes
Update combinedQueryVulnerabilities operation limit. Closes #922.
e6373eb
@jshcodes jshcodes mentioned this issue Feb 27, 2023
Merged
3 tasks
jshcodes added a commit that referenced this issue Feb 27, 2023
@jshcodes
Update combinedQueryVulnerabilities operation limit. Closes #922.
0a7e383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
API usage General API usage issues and questions documentation 📖 Improvements or additions to documentation spotlight Spotlight issues and questions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 1.2.12 - New KubernetesProtection operations, fixes CrowdStrike/falconpy
2 participants
@cactusjuan @jshcodes