[EP-2362] Save contact info after sign up #1130
Open
+101
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-bizz
approved these changes
Jan 8, 2025
| @@ -1,4 +1,4 @@ | |||
| <contact-info submitted="$ctrl.submitted" on-submit="$ctrl.onSubmit(success)"></contact-info> | |||
| <contact-info submitted="$ctrl.submitted" on-submit="$ctrl.onSubmit(success)" donor-details="$ctrl.signUpDonorDetails"></contact-info> | |||
There was a problem hiding this comment.
Where is signUpDonorDetails defined? Were you also meant to commit changes to the contactInfoModal.component.js
There was a problem hiding this comment.
It is set in checkDonorDetails if there was an error saving the donor details
Comment on lines
+34
to
+35
| on-sign-up="$ctrl.onSignUp(donorDetails)" | ||
| on-sign-in="$ctrl.onSignIn()" |
There was a problem hiding this comment.
You also need to update the file src/common/services/session/sessionModal.tpl.html as signUpModal is also used there
| @@ -148,13 +148,36 @@ class SignUpModalController { | |||
| } | |||
| onSuccess(postData) | |||
| } | |||
| }, | |||
| // TODO: make sure that this callback is only called after the sign up completes successfully | |||
| postSubmit: (postData, onSuccess) => { | |||
There was a problem hiding this comment.
It looks like this is fired after the Registration API is fired to Okta, but before registration is completed. I think that is okay, bt as you said, we will need to check
canac
force-pushed
the
2362-okta-save-contact-info
branch
from
e146d50 to
5efb9d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
onStateChangebinding with dedicatedonSignUpandonSignInbindingsI made this a PR instead of committing directly so it's easier for you to see what changed and see if I'm going in the right direction with this.