fixing tests that broke to the merge conflict fixes

CruGlobal · Aug 22, 2024 · 43047d2 · 43047d2
1 parent 4e6f858
commit 43047d2
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 30 deletions.
diff --git a/pages/accountLists/[accountListId]/tools/appeals/appeal/[[...appealId]].page.test.tsx b/pages/accountLists/[accountListId]/tools/appeals/appeal/[[...appealId]].page.test.tsx
@@ -112,7 +112,7 @@ const Components = ({ router = defaultRouter }: { router?: object }) => (
 );
 
 describe('Appeal navigation', () => {
-  it('should show list detail appeal page and open filters', async () => {
+  it('should show list detail appeal page and close filters', async () => {
     const { getByText, findByTestId, queryByText, getByRole, queryByRole } =
       render(
         <Components
@@ -134,16 +134,6 @@ describe('Appeal navigation', () => {
     await waitFor(() => expect(getByText('Test Person')).toBeInTheDocument());
     expect(await findByTestId('rowButton')).toHaveTextContent(contact.name);
 
-    expect(queryByRole('heading', { name: 'Given' })).not.toBeInTheDocument();
-    expect(
-      queryByRole('heading', { name: 'Received' }),
-    ).not.toBeInTheDocument();
-    expect(
-      queryByRole('heading', { name: 'Committed' }),
-    ).not.toBeInTheDocument();
-
-    userEvent.click(getByRole('img', { name: 'Toggle Filter Panel' }));
-
     await waitFor(() => {
       expect(getByRole('heading', { name: 'Given' })).toBeInTheDocument();
       expect(getByRole('heading', { name: 'Received' })).toBeInTheDocument();
@@ -156,6 +146,18 @@ describe('Appeal navigation', () => {
         getByRole('heading', { name: 'Export Emails' }),
       ).toBeInTheDocument();
     });
+
+    userEvent.click(getByRole('img', { name: 'Toggle Filter Panel' }));
+
+    await waitFor(() => {
+      expect(queryByRole('heading', { name: 'Given' })).not.toBeInTheDocument();
+      expect(
+        queryByRole('heading', { name: 'Received' }),
+      ).not.toBeInTheDocument();
+      expect(
+        queryByRole('heading', { name: 'Committed' }),
+      ).not.toBeInTheDocument();
+    });
   });
 
   it('should show flows detail appeal page and open filters', async () => {

diff --git a/src/components/Tool/Appeal/AppealsDetailsPage.test.tsx b/src/components/Tool/Appeal/AppealsDetailsPage.test.tsx
@@ -117,17 +117,18 @@ const Components = ({ router = defaultRouter }: { router?: object }) => (
 describe('AppealsDetailsPage', () => {
   describe('Contact drawer', () => {
     it('should open and close on List view', async () => {
-      const { getByText, findByTestId, getByRole, queryByRole } = render(
-        <Components
-          router={{
-            ...defaultRouter,
-            query: {
-              ...defaultRouter.query,
-              appealId: ['1', 'list'],
-            },
-          }}
-        />,
-      );
+      const { getByText, findByTestId, getByRole, queryByRole, getAllByRole } =
+        render(
+          <Components
+            router={{
+              ...defaultRouter,
+              query: {
+                ...defaultRouter.query,
+                appealId: ['1', 'list'],
+              },
+            }}
+          />,
+        );
 
       await waitFor(() => expect(getByText('Test Person')).toBeInTheDocument());
 
@@ -140,7 +141,7 @@ describe('AppealsDetailsPage', () => {
         expect(getByRole('tab', { name: 'Tasks' })).toBeInTheDocument(),
       );
 
-      userEvent.click(getByRole('img', { name: 'Close' }));
+      userEvent.click(getAllByRole('img', { name: 'Close' })[0]);
 
       await waitFor(() =>
         expect(queryByRole('tab', { name: 'Tasks' })).not.toBeInTheDocument(),

diff --git a/src/components/Tool/Appeal/List/ContactRow/ContactRow.test.tsx b/src/components/Tool/Appeal/List/ContactRow/ContactRow.test.tsx
@@ -115,12 +115,16 @@ describe('ContactsRow', () => {
     expect(setContactFocus).toHaveBeenCalledWith(contact.id);
   });
 
-  it('should rendered checked', () => {
-    isRowChecked.mockImplementationOnce(() => true);
+  it('should render contact select event', () => {
+    isRowChecked.mockImplementationOnce((id) => id === contact.id);
 
-    const { getByRole } = render(<Components />);
+    const { getByTestId } = render(<Components />);
 
-    const checkbox = getByRole('checkbox');
-    expect(checkbox).toBeChecked();
+    expect(setContactFocus).not.toHaveBeenCalled();
+
+    const rowButton = getByTestId('rowButton');
+    userEvent.click(rowButton);
+
+    expect(setContactFocus).toHaveBeenCalledWith(contact.id);
   });
 });
diff --git a/src/components/Tool/FixMailingAddresses/FixMailingAddresses.test.tsx b/src/components/Tool/FixMailingAddresses/FixMailingAddresses.test.tsx
@@ -437,7 +437,7 @@ describe('FixMailingAddresses', () => {
             InvalidAddresses: {
               ...mockInvalidAddressesResponse.InvalidAddresses,
             },
-            UpdateContactMailingAddress: () => {
+            UpdateContactAddress: () => {
               throw new Error('Server Error');
             },
           }}
@@ -519,7 +519,7 @@ describe('FixMailingAddresses', () => {
                 ],
               },
             },
-            UpdateContactMailingAddress: () => {
+            UpdateContactAddress: () => {
               throw new Error('Server Error');
             },
           }}