Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8089] Add setup connect page #1009

Merged
merged 8 commits into from
Aug 28, 2024
Merged

[MPDX-8089] Add setup connect page #1009

merged 8 commits into from
Aug 28, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Aug 26, 2024

Description

  • Refactor the add organization modal component so that it can be used on the integrations page and on the setup connect page
  • Add setup connect page

MPDX-8089

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Aug 26, 2024
@canac canac requested a review from dr-bizz August 26, 2024 19:30
Copy link
Contributor

Preview branch generated at https://8089-setup-connect-page.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

github-actions bot commented Aug 26, 2024

Bundle sizes [mpdx-react]

Compared against d4bcf7f

Route Size (gzipped) Diff
/accountLists/[accountListId]/settings/integrations 161.78 KB +2.44 KB
/setup/connect 129.25 KB added

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. The code looks great.

If we make the start page look like what I sent in, can we also make this page look similar?

Header text: font-size: 2.75rem
Icon colour: primary
Paragraph - max-width: 500px
Card max-width: 580px

I forgot to take a screenshot.

<SetupPage
title={
organizationAccounts.length
? t("It's time for awesome!")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In see this was in the old MPDX, but should this be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not attached to having a different message when the user has organizations connected. I was just copying the existing implementation. Let me know if you don't like it.

src/components/Setup/Connect.tsx Show resolved Hide resolved
@canac canac requested a review from dr-bizz August 28, 2024 15:28
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As my changes are minor I will approve the PR. Great work.

Could you make the title on the connect the same size as the start page?

@canac
Copy link
Contributor Author

canac commented Aug 28, 2024

Could you make the title on the connect the same size as the start page?

Definitely! This builds on the PR that creates and styles that page, so changes there will apply here too once I merge the first PR.

@canac canac force-pushed the 8088-setup-start-page branch from a135d1a to 970597b Compare August 28, 2024 18:48
Base automatically changed from 8088-setup-start-page to main August 28, 2024 18:57
@canac canac force-pushed the 8089-setup-connect-page branch from 3a4d75b to 2490da9 Compare August 28, 2024 19:06
@canac canac merged commit ec9c73f into main Aug 28, 2024
18 checks passed
@canac canac deleted the 8089-setup-connect-page branch August 28, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants