-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPDX-8089] Add setup connect page #1009
Conversation
Preview branch generated at https://8089-setup-connect-page.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against d4bcf7f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. The code looks great.
If we make the start page look like what I sent in, can we also make this page look similar?
Header text: font-size: 2.75rem
Icon colour: primary
Paragraph - max-width: 500px
Card max-width: 580px
I forgot to take a screenshot.
src/components/Settings/integrations/Organization/ConnectOrganization.tsx
Show resolved
Hide resolved
<SetupPage | ||
title={ | ||
organizationAccounts.length | ||
? t("It's time for awesome!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In see this was in the old MPDX, but should this be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not attached to having a different message when the user has organizations connected. I was just copying the existing implementation. Let me know if you don't like it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As my changes are minor I will approve the PR. Great work.
Could you make the title on the connect the same size as the start page?
Definitely! This builds on the PR that creates and styles that page, so changes there will apply here too once I merge the first PR. |
a135d1a
to
970597b
Compare
Any button prop can now be overridden
3a4d75b
to
2490da9
Compare
Description
MPDX-8089
Checklist: