-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appeal list filters #1011
Merged
Merged
Appeal list filters #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle sizes [mpdx-react]Compared against 3ce23f2
|
If |
canac
requested changes
Aug 28, 2024
src/components/Tool/Appeal/Modals/AddContactToAppealModal/appealInfo.graphql
Outdated
Show resolved
Hide resolved
src/components/Tool/Appeal/Modals/AddContactToAppealModal/AddContactToAppealModal.tsx
Outdated
Show resolved
Hide resolved
src/components/Tool/Appeal/Modals/AddContactToAppealModal/AddContactToAppealModal.tsx
Outdated
Show resolved
Hide resolved
src/components/Tool/Appeal/Modals/AddContactToAppealModal/AddContactToAppealModal.test.tsx
Show resolved
Hide resolved
src/components/Tool/Appeal/Modals/DeleteAppealModal/DeleteAppealModal.tsx
Outdated
Show resolved
Hide resolved
src/components/Tool/Appeal/Modals/DeleteAppealModal/DeleteAppealModal.tsx
Show resolved
Hide resolved
src/components/Tool/Appeal/Modals/AddContactToAppealModal/AddContactToAppealModal.tsx
Show resolved
Hide resolved
The increase of files changed is due to appealInfo.graphQL being reworded in both places. |
canac
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work addressing everything from the last review!
dr-bizz
force-pushed
the
appeal-list-filters
branch
from
August 28, 2024 15:57
2bad961
to
2e837dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I added functionality to the list view filter buttons. This includes exporting contacts & emails, adding contacts to appeals and deleting appeals. All models are dynamically loaded and preloaded when the mouse is hovered over the button that opens the modal in question.
Fixes
Export contacts & emails
These models already existed, so there was less work to get them working.
Add Contacts Modal
Created a new modal that allows the user to add contacts to the appeal.
<ContactsAutocomplete/>
to exclude contact IDs so the user doesn't see contacts that are already a part of the appeal.Delete Appeal Modal
Created this modal to allow the user to delete the appeal.
Checklist: