Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appeal list filters #1011

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Appeal list filters #1011

merged 6 commits into from
Aug 28, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Aug 27, 2024

Description

In this PR, I added functionality to the list view filter buttons. This includes exporting contacts & emails, adding contacts to appeals and deleting appeals. All models are dynamically loaded and preloaded when the mouse is hovered over the button that opens the modal in question.

Fixes

  • Updated the panel contact number if the user searched to show how many contacts are under each appeal status.
  • Added the ability to load dynamic components on the filter panel buttons on the mouse hover

Export contacts & emails

These models already existed, so there was less work to get them working.

Add Contacts Modal

Created a new modal that allows the user to add contacts to the appeal.

  • Edited the<ContactsAutocomplete/> to exclude contact IDs so the user doesn't see contacts that are already a part of the appeal.
  • Refreshes the contacts list to show new contacts in the contact list.

Delete Appeal Modal

Created this modal to allow the user to delete the appeal.

  • after deletion, it redirects to the user back to the appeals page

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz requested a review from canac August 27, 2024 20:53
Copy link
Contributor

github-actions bot commented Aug 27, 2024

Bundle sizes [mpdx-react]

Compared against 3ce23f2

Dynamic import Size (gzipped) Diff
../src/components/Tool/Appeal/Modals/AddContactToAppealModal/DynamicAddContactToAppealModal.tsx -> ./AddContactToAppealModal 3.5 KB added
../src/components/Tool/Appeal/Modals/DeleteAppealModal/DynamicDeleteAppealModal.tsx -> ./DeleteAppealModal 2.29 KB added

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Aug 27, 2024

If codecov/patch is above 80% I have been approving PRs as that is a pass in my book.

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Aug 28, 2024

The increase of files changed is due to appealInfo.graphQL being reworded in both places.

@dr-bizz dr-bizz requested a review from canac August 28, 2024 15:23
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work addressing everything from the last review!

@dr-bizz dr-bizz force-pushed the appeal-list-filters branch from 2bad961 to 2e837dc Compare August 28, 2024 15:57
@dr-bizz dr-bizz merged commit ab981ab into main Aug 28, 2024
17 of 18 checks passed
@dr-bizz dr-bizz deleted the appeal-list-filters branch August 28, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants