Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPDX-8094] Add setup finish page #1025

Merged
merged 4 commits into from
Sep 4, 2024
Merged

[MPDX-8094] Add setup finish page #1025

merged 4 commits into from
Sep 4, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Aug 30, 2024

Description

  • Add setup finish page
  • The logic on the tools page to notice the ?setup=1 query parameter will be done as part of MPDX-8095
  • Adding logic to redirect to this page can either be done in MPDX-8091 Preferences Setup steps UI #1002 or in a future PR

MPDX-8094

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Aug 30, 2024
@canac canac requested a review from dr-bizz August 30, 2024 20:33
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://8094-setup-finish-page.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 30, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 20ce9ed

Route Size (gzipped) Diff
/accountLists/[accountListId]/setup/finish 86.56 KB added

dr-bizz
dr-bizz reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I had one question as it looks like you are redirect to settings instead of tools.

pages/setup/finish.page.tsx Outdated Show resolved Hide resolved
@canac canac requested a review from dr-bizz September 3, 2024 16:28
dr-bizz
dr-bizz approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@canac canac force-pushed the 8094-make-get-server-side-props branch 2 times, most recently from 491d3ec to 5baad8e Compare September 4, 2024 15:54
Base automatically changed from 8094-make-get-server-side-props to main September 4, 2024 16:21
@canac canac force-pushed the 8094-setup-finish-page branch from 53ecac2 to 671879b Compare September 4, 2024 16:30
@canac canac merged commit e51dddf into main Sep 4, 2024
18 checks passed
@canac canac deleted the 8094-setup-finish-page branch September 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees
No one assigned
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz