Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8154 Add Contact Button and fix Star filtering #1037

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Sep 6, 2024

Description

In this PR, I fix the star filtering on the Flows view. I also added the "Add Contact to Appeal" button to the asked column. Refreshing the contacts queries once contacts are added.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz requested a review from canac September 6, 2024 19:11
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Bundle sizes [mpdx-react]

Compared against 3d9d163

Dynamic import Size (gzipped) Diff
../src/components/Tool/Appeal/Modals/AddContactToAppealModal/DynamicAddContactToAppealModal.tsx -> ./AddContactToAppealModal 39.15 KB +35.69 KB

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 🔥

expect(await findByText('Add Contact(s) to Appeal')).toBeInTheDocument();
});

it('should not have the "Add Contact to Appeal" button', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('should not have the "Add Contact to Appeal" button', async () => {
it('other columns should not have the "Add Contact to Appeal" button', async () => {

@dr-bizz dr-bizz merged commit 4ef692e into main Sep 9, 2024
18 checks passed
@dr-bizz dr-bizz deleted the MPDX-8154 branch September 9, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants