MPDX-8181 - Showing excluded contacts message when adding contacts that are excluded #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle sizes [mpdx-react]Compared against 6589899 No significant changes found |
canac
changed the title
canac
reviewed
Sep 10, 2024
src/components/Tool/Appeal/Modals/AddContactToAppealModal/AddContactToAppealModal.tsx
Outdated
Show resolved
Hide resolved
src/components/Tool/Appeal/Modals/AddContactToAppealModal/AddContactToAppealModal.tsx
Outdated
Show resolved
Hide resolved
src/components/Tool/Appeal/Modals/AddContactToAppealModal/AddContactToAppealModal.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Tool/Appeal/Modals/AddContactToAppealModal/AddContactToAppealModal.tsx
Outdated
Show resolved
Hide resolved
…e currently excluded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I add a message to the add Contact modal to inform the user that they are adding excluded contacts.
In the old MPDX, they close the modal and open the add excluded modal, but since I allow multiple contacts to be added and I think it's better UX, I have added an info alert that shows when an excluded contact is selected.
I also list out the excluded contact names.
I have added tests for this new functionality.
This PR is related to task MPDX-8181 not 1880. My mistake.
Checklist: