MPDX-8184 - Remove zero amount confirmation and logic and replace with a error #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssage stating pledges cannot be set to zero. In this commit I also add snackbar to the graphQL request to show the user what is going on and I fixed am issue with the new commitment currency.
dr-bizz
changed the title
Bundle sizes [mpdx-react]Compared against a20bb7e No significant changes found |
…ng a new commitment/pledge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I remove the zero total amount in the update donations modal and fix some other bugs/ UX issues. MPDX-8184
After talking with Scott at our Stand up, we decided to remove the zero logic which sends the pledge to either
askedor receivedand instead add a error message informing the user that they can't create/update a pledge to have a$0` amount.I added snackbar messages to the graphQL request to give feedback to the user.
I fixed a small issue with the create pledge functionality as it wasn't assigning a currency.
Checklist: