[MPDX-8193] Preselect new appeal options #1059
Conversation
|
Preview branch generated at https://8193-appeal-preselected-options.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 0712f37 No significant changes found |
| <AddAppealForm | ||
| accountListId={accountListId || ''} | ||
| appealStatuses={[ | ||
| { | ||
| name: '-- All Active --', | ||
| value: 'ACTIVE', | ||
| }, | ||
| ]} | ||
| appealExcludes={contactExclusions.filter( | ||
| (exclusion) => | ||
| exclusion.value === ExclusionEnum.DoNotAskAppeals, | ||
| )} | ||
| /> |
There was a problem hiding this comment.
These changes need to be added to the form itself as this is the default.
Can you move these changes inside the <AddAppealForm/>?
There was a problem hiding this comment.
Why does AddAppealForm accept props to initialize the form then? Can those props all be removed?
There was a problem hiding this comment.
It accepts props as they will be used in the announcements, which can pass down appeal statements and appeal excludes.
Can we make the appealStatuses and appealExcludes have a default value of what you have above?
There was a problem hiding this comment.
It uses it in the old one here: src/tools/appeals/appeals.service.ts Line 62 "oneClickAppeal"
canac
force-pushed
the
8193-appeal-preselected-options
branch
from
5a525e6 to
ada2107
Compare
Description
Add contacts with the following status(es):to-- All Active --Do not add contacts who:toHave "Send Appeals" set to NoChecklist: