MPDX-8205 Style CSV #1063
Merged
MPDX-8205 Style CSV #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleballdrin
added
the
Preview Environment
|
Preview branch generated at https://MPDX-8205-style-csv.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 0712f37
|
wrandall22
reviewed
Sep 13, 2024
| @@ -182,7 +182,7 @@ export const useSupportedHeaders = () => { | |||
| }; | |||
|
|
|||
| export const useRequiredHeaders = () => { | |||
| const hardCodedRequiredHeaders = ['first_name', 'last_name', 'full_name']; | |||
| const hardCodedRequiredHeaders = ['first_name', 'last_name']; | |||
There was a problem hiding this comment.
See equivalent logic here. I believe this change is a regression and not the right way to solve the problem you're trying to solve.
canac
reviewed
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8205&sprint=1259#
Checklist: