MPDX-8216 - tools - fix commitment info - suggested changes

[wjames111]

Description

• Suggested Changes Needs to be the default and not the fallback
• Ticket #8131 MPDX-8131

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
• I have requested a review from another person on the project

[github-actions]

Preview branch generated at https://MPDX-8216-fix-commitment-info-suggested-changes.d3dytjb8adxkk5.amplifyapp.com

[github-actions]

Bundle sizes [mpdx-react]

Compared against f06e55b

No significant changes found

[wjames111]

@caleballdrin I talked with Andrew and unfortunately we can't get graphql fields for suggested changes, they need to be in JSON. Kind of unfortunate but not a big deal.

I researched a little more what's going on with the old MPDx. Like you said, It appears suggested changes is used as the default for populating the form. It also looks like the other graphql fields are used as a fallback.

In light of that I think all that's really needed is to switch around the pledgeAmount and pledgeFrequency. Does that sound right or do you think we need a different solution.

[dr-bizz]

@wjames111 I wonder if you could fetch them using the GQL proxy?

[wjames111]

@dr-bizz Never done that before, I could see if that works. I am currently able to get the suggested changes they're just in json format rather then gql. So it's just a matter of convenience. Would using the proxy get me gql fields or is it json as well?

[dr-bizz]

Oh, I see. I would use what you have then (Not use proxy) and convert the JSON to what you need and use it.

Can you not use the JSON as is

[caleballdrin]

@canac Can you help us make sense of this? We don't know if Fix Commitment Info should set the initial values to blank, the suggested values, or the current values. On my personal account, it appears that it sets the initial values to the suggested values and leaves it blank if there is no suggested value.

However, in the Angular code, the mutateContacts service appears to use defaultTo to set the initial value to the original/current value and only use the suggested value if it doesn't have one. I was thinking you might be able to understand the angular better than we can.

https://github.com/CruGlobal/mpdx_web/blob/19c03ae0689609eeee8b9b516700cc75ee4f3f79/src/tools/fix/commitment/commitment.service.ts

[dr-bizz]

On your account, is there a way to log out the contact.pledge_amount? I wonder if this is blank, which is why it's showing blank.

When you say blank, do you mean like this? where it only shows the "0" placeholder for the amount.

[dr-bizz]

If so, this is because the pledge amount is null and there is no contact.suggested_changes.pledge_amount

[dr-bizz]

Your code should read

pledgeAmount: suggestedAmount || amount,

[dr-bizz]

Let me know if that makes sense

[dr-bizz]

Does that make sense?

[dr-bizz]

status: suggestedChanges.status || statusValue

[wjames111]

@dr-bizz so to clarify?

[dr-bizz]

Yes, that is correct

[caleballdrin]

Nice. So we have confirmed that the suggested values (status, frequency, amount) should be the initial form values. If they don't exist, then it will set the current values as the initial form values.

[caleballdrin]

Looks good!