Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No Jira] Import router in client.ts #1086

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[No Jira] Import router in client.ts #1086

merged 1 commit into from
Sep 23, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

Import router in client.ts so router.replace from _app.page doesn't interfere with the replace in contacts context.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Sep 23, 2024
@caleballdrin caleballdrin requested a review from canac September 23, 2024 17:05
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://fix-contacts-router.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against a536cc4

No significant changes found

canac
canac approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well on contacts and 14 month report pages with valid and invalid account list ids!

Bug fix for issue in #1084

@caleballdrin caleballdrin merged commit 6c1e09f into main Sep 23, 2024
18 of 19 checks passed
@caleballdrin caleballdrin deleted the fix-contacts-router branch September 23, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

Assignees

@caleballdrin caleballdrin

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleballdrin @canac