Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the result based on the displayResults and the default to com… #1094

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Sep 25, 2024

Description

In this PR, If the result is left blank on the log task modal form, it defaults it to COMPLETED.

I'm unsure if this is the correct functionality, as it's been some time since I edited this and I can't find anywhere that mentions what we should o in this case. the other option is that it always runs the getDatabaseValueFromResult, so if there is not a result selected, it defaults to NONE.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 1d69035

Route Size (gzipped) Diff
/_app 373.17 KB +1.51 KB
/accountLists 119.31 KB -1.2 KB
/accountLists/[accountListId] 271.03 KB -1021 B
/accountLists/[accountListId]/coaching/[coachingId] 247.81 KB +1.57 KB
/accountLists/[accountListId]/contacts/flows/setup 180.36 KB +32.54 KB
/accountLists/[accountListId]/reports/coaching 247.81 KB +1.57 KB
/accountLists/[accountListId]/reports/donations/[[...contactId]] 344.53 KB -2.05 KB
/accountLists/[accountListId]/reports/expectedMonthlyTotal 110.36 KB +1.69 KB
/accountLists/[accountListId]/reports/partnerCurrency/[[...contactId]] 136.22 KB +2.19 KB
/accountLists/[accountListId]/reports/salaryCurrency/[[...contactId]] 136.22 KB +2.19 KB
/accountLists/[accountListId]/settings/integrations 161.78 KB -2 KB
/accountLists/[accountListId]/settings/manageAccounts 142.42 KB -1.98 KB
/accountLists/[accountListId]/settings/manageCoaches 138.97 KB -1.21 KB
/accountLists/[accountListId]/settings/organizations 136.68 KB -1.07 KB
/accountLists/[accountListId]/settings/preferences 212.4 KB -1.05 KB
/accountLists/[accountListId]/tasks/[[...contactId]] 140.73 KB +2.95 KB
/accountLists/[accountListId]/tools 142.29 KB -1.14 KB
/accountLists/[accountListId]/tools/fix/commitmentInfo/[[...contactId]] 258.69 KB +10.29 KB
/accountLists/[accountListId]/tools/fix/phoneNumbers/[[...contactId]] 259.08 KB +111.29 KB
/accountLists/[accountListId]/tools/fix/sendNewsletter/[[...contactId]] 117.36 KB -1.22 KB
/accountLists/[accountListId]/tools/import/csv 106.89 KB -1.22 KB
/accountLists/[accountListId]/tools/import/google 156.31 KB -2.32 KB
/accountLists/[accountListId]/tools/import/tnt 149.96 KB -2.86 KB
/login 119.37 KB -1.02 KB
Dynamic import Size (gzipped) Diff
../src/components/Contacts/ContactDetails/ContactDetailsTab/DynamicContactDetailsTab.tsx -> ./ContactDetailsTab 66.57 KB -9.04 KB
../src/components/Contacts/ContactDetails/ContactDonationsTab/DynamicContactDonationsTab.tsx -> ./ContactDonationsTab 182.22 KB -7.96 KB
../src/components/Contacts/ContactFlow/DynamicContactFlow.tsx -> ./ContactFlow 67.16 KB +6.05 KB
../src/components/Contacts/ContactsList/DynamicContactsList.tsx -> ./ContactsList 44.71 KB +1.81 KB
../src/components/Contacts/ContactsMap/DynamicContactsMap.tsx -> ./ContactsMap 32.38 KB +1.63 KB
../src/components/Contacts/ContactsMap/DynamicContactsMapPanel.tsx -> ./ContactsMapPanel 8.04 KB +1.8 KB
../src/components/Contacts/ContactsRightPanel/DynamicContactsRightPanel.tsx -> ./ContactsRightPanel 142.43 KB +10.38 KB
../src/components/Contacts/MassActions/Exports/Emails/DynamicMassActionsExportEmailsModal.tsx -> ./MassActionsExportEmailsModal 2.08 KB -1.02 KB
../src/components/Dashboard/ThisWeek/NewsletterMenu/MenuItems/LogNewsLetter/DynamicLogNewsletter.tsx -> ./LogNewsletter 89.88 KB -1.06 KB
../src/components/Dashboard/ThisWeek/WeeklyActivity/WeeklyReportModal/DynamicWeeklyReportModal.tsx -> ./WeeklyReportModal 33.15 KB -1.39 KB
../src/components/EditDonationModal/DynamicEditDonationModal.tsx -> ./EditDonationModal 76.23 KB +2.1 KB
../src/components/Layouts/Primary/TopBar/Items/AddMenu/Items/CreateMultipleContacts/DynamicCreateMultipleContacts.tsx -> ./CreateMultipleContacts 76.61 KB +1.49 KB
../src/components/Task/Modal/Form/Complete/DynamicTaskModalCompleteForm.tsx -> ./TaskModalCompleteForm 111.12 KB +12.47 KB
../src/components/Task/Modal/Form/DynamicTaskModalForm.tsx -> ./TaskModalForm 120.96 KB +14.42 KB
../src/components/Task/Modal/Form/LogForm/DynamicTaskModalLogForm.tsx -> ./TaskModalLogForm 149.7 KB +9.56 KB
../src/components/Tool/Appeal/Flow/DynamicContactFlow.tsx -> ./ContactFlow 67.16 KB +6.05 KB
../src/components/Tool/Appeal/List/ContactsList/DynamicContactsList.tsx -> ./ContactsList 44.71 KB +1.81 KB
../src/components/Tool/Appeal/Modals/PledgeModal/DynamicPledgeModal.tsx -> ./PledgeModal 74.04 KB -1.03 KB
../src/components/Tool/Appeal/Modals/UpdateDonationsModal/DynamicUpdateDonationsModal.tsx -> ./UpdateDonationsModal 103.47 KB -2.02 KB

Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think setting it to COMPLETED if there is no result is a good plan.

@dr-bizz dr-bizz merged commit d78df37 into MPDX-task-phases-new Sep 26, 2024
17 checks passed
@dr-bizz dr-bizz deleted the log-task-result branch September 26, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants