Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8306 Add phase grouping of statuses #1100

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Sep 26, 2024

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8306&sprint=1268#

  • Group statuses by phase in filters

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Sep 26, 2024
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Bundle sizes [mpdx-react]

Compared against 0f716c5

Route Size (gzipped) Diff
/_app 373.5 KB +1.44 KB
/accountLists 119.31 KB -1.2 KB
/accountLists/[accountListId]/coaching/[coachingId] 247.82 KB +1.47 KB
/accountLists/[accountListId]/contacts/flows/setup 180.67 KB +32.84 KB
/accountLists/[accountListId]/reports/coaching 247.83 KB +1.52 KB
/accountLists/[accountListId]/reports/designationAccounts 244.02 KB +2.42 KB
/accountLists/[accountListId]/reports/expectedMonthlyTotal 111.1 KB +2.47 KB
/accountLists/[accountListId]/reports/partnerCurrency/[[...contactId]] 135.95 KB +2.02 KB
/accountLists/[accountListId]/reports/partnerGivingAnalysis/[[...contactId]] 135.29 KB +2.45 KB
/accountLists/[accountListId]/reports/responsibilityCenters 244.96 KB +2.41 KB
/accountLists/[accountListId]/reports/salaryCurrency/[[...contactId]] 135.95 KB +2.02 KB
/accountLists/[accountListId]/settings/admin 137.19 KB +1.31 KB
/accountLists/[accountListId]/settings/manageCoaches 141.39 KB +1.3 KB
/accountLists/[accountListId]/settings/notifications 138.97 KB +1.41 KB
/accountLists/[accountListId]/settings/organizations 138.99 KB +1.3 KB
/accountLists/[accountListId]/settings/organizations/accountLists 140.88 KB +1.46 KB
/accountLists/[accountListId]/settings/organizations/contacts 137.68 KB +1.46 KB
/accountLists/[accountListId]/tasks/[[...contactId]] 139.64 KB +1.8 KB
/accountLists/[accountListId]/tools 142.31 KB -1.09 KB
/accountLists/[accountListId]/tools/appeals/appeal/[[...appealId]] 218.15 KB +1.74 KB
/accountLists/[accountListId]/tools/fix/sendNewsletter/[[...contactId]] 117.38 KB -1.17 KB
/accountLists/[accountListId]/tools/import/csv 106.91 KB -1.17 KB
/accountLists/[accountListId]/tools/import/google 156.33 KB -2.27 KB
/accountLists/[accountListId]/tools/import/tnt 149.98 KB -2.81 KB
/login 119.37 KB -1.02 KB
Dynamic import Size (gzipped) Diff
../src/components/Contacts/ContactFlow/DynamicContactFlow.tsx -> ./ContactFlow 67.54 KB +6.43 KB
../src/components/Contacts/ContactsList/DynamicContactsList.tsx -> ./ContactsList 44.75 KB +1.85 KB
../src/components/Contacts/ContactsMap/DynamicContactsMap.tsx -> ./ContactsMap 32.38 KB +1.57 KB
../src/components/Contacts/ContactsMap/DynamicContactsMapPanel.tsx -> ./ContactsMapPanel 8.05 KB +1.8 KB
../src/components/Contacts/MassActions/Exports/Emails/DynamicMassActionsExportEmailsModal.tsx -> ./MassActionsExportEmailsModal 2.08 KB -1.02 KB
../src/components/Dashboard/ThisWeek/NewsletterMenu/MenuItems/LogNewsLetter/DynamicLogNewsletter.tsx -> ./LogNewsletter 89.77 KB -1.17 KB
../src/components/Dashboard/ThisWeek/WeeklyActivity/WeeklyReportModal/DynamicWeeklyReportModal.tsx -> ./WeeklyReportModal 33.15 KB -1.39 KB
../src/components/Layouts/Primary/TopBar/Items/AddMenu/Items/CreateMultipleContacts/DynamicCreateMultipleContacts.tsx -> ./CreateMultipleContacts 76.62 KB +1.49 KB
../src/components/Shared/Filters/DynamicFilterPanel.tsx -> ./FilterPanel 108.08 KB +2.55 KB
../src/components/Task/Modal/Form/Complete/DynamicTaskModalCompleteForm.tsx -> ./TaskModalCompleteForm 111.19 KB +12.53 KB
../src/components/Task/Modal/Form/DynamicTaskModalForm.tsx -> ./TaskModalForm 119.27 KB +12.71 KB
../src/components/Task/Modal/Form/LogForm/DynamicTaskModalLogForm.tsx -> ./TaskModalLogForm 149.91 KB +9.78 KB
../src/components/Tool/Appeal/Flow/DynamicContactFlow.tsx -> ./ContactFlow 67.54 KB +6.43 KB
../src/components/Tool/Appeal/List/ContactsList/DynamicContactsList.tsx -> ./ContactsList 44.75 KB +1.85 KB
../src/components/Tool/Appeal/Modals/UpdateDonationsModal/DynamicUpdateDonationsModal.tsx -> ./UpdateDonationsModal 103.91 KB -1.58 KB

@caleballdrin caleballdrin requested review from canac and dr-bizz and removed request for canac September 27, 2024 15:00
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues, so I'm going to approve. Sorting the options seems like something that should potentially be done on the server, so that we don't have to have as many special cases for certain filters. But we need a special case to group them, so it's not a big deal. And it's probably more work to add a group field on the server to the status options.

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Caleb C has approved this, I'm good merging it once he approves it

@caleballdrin caleballdrin requested a review from canac September 30, 2024 06:10
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to slow this down, but I have a couple other suggestions.

@caleballdrin caleballdrin requested a review from canac September 30, 2024 16:30
@caleballdrin caleballdrin merged commit ca9d8a2 into MPDX-task-phases-new Sep 30, 2024
18 checks passed
@caleballdrin caleballdrin deleted the MPDX-8306-status-by-phase branch September 30, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants