-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-8306 Add phase grouping of statuses #1100
Conversation
Bundle sizes [mpdx-react]Compared against 0f716c5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any issues, so I'm going to approve. Sorting the options seems like something that should potentially be done on the server, so that we don't have to have as many special cases for certain filters. But we need a special case to group them, so it's not a big deal. And it's probably more work to add a group
field on the server to the status options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Caleb C has approved this, I'm good merging it once he approves it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to slow this down, but I have a couple other suggestions.
Description
https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8306&sprint=1268#
Checklist: