Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RC message #1105

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Add RC message #1105

merged 4 commits into from
Sep 30, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

  • Add message telling users that Responsibility Centers is not working.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Sep 30, 2024
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 0f716c5

No significant changes found

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looos great. I had one suggestion but will approve.

@@ -215,7 +215,7 @@ export const ResponsibilityCentersReport: React.FC<Props> = ({
<ScrollBox data-testid="ResponsibilityCentersScrollBox">
<Alert severity="warning">
{t(
'Responsibility Centers is still in development. Some features are not working. Please check back later.',
'Responsibility Centers is still in development and may not be complete until October 11th. Please check back later.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd hesitate to give an exact date. It doesn't give much flexibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think it should say?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few days, like Daniel said, seems sufficient.

@caleballdrin caleballdrin merged commit 2f9d4a3 into main Sep 30, 2024
18 checks passed
@caleballdrin caleballdrin deleted the add-rc-message branch September 30, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants