[MPDX-8341] Fix coaching Connections Remaining link filter #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you have HELP_URL_* env vars set locally, these tests were failing because other links were in the document.
|
Preview branch generated at https://8339-connections-remaining-filter.d3dytjb8adxkk5.amplifyapp.com |
canac
changed the title
Bundle sizes [mpdx-react]Compared against 348e611 No significant changes found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
status === nullfilter from the Connections Remaining link on the coaching report page.To test, go to Reports > Coaching, then click on the Connections Remaining link. Verify that the number on the coaching report matches the number of contacts showing on the contacts page. Before, too many contacts were showing because it was including contacts with a null status.
MPDX-8341
Checklist: