HelpScout Tasks Search

[caleballdrin]

Description

https://secure.helpscout.net/conversation/2726128388/1238886?folderId=7669074

• Show tooltip so users know what they can search for
• Automatically show the filters on Contacts and Tasks
• Fix amperstand on welcome message

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
• I have requested a review from another person on the project

[github-actions]

Preview branch generated at https://helpscout-tasks-search.d3dytjb8adxkk5.amplifyapp.com

[github-actions]

Bundle sizes [mpdx-react]

Compared against d4b2075

Route	Size (gzipped)	Diff
/accountLists/[accountListId]/contacts/[[...contactId]]	109.18 KB	+3.5 KB
/accountLists/[accountListId]/contacts/flows/setup	184.05 KB	+3.51 KB
/accountLists/[accountListId]/tools	145.64 KB	+3.5 KB
/accountLists/[accountListId]/tools/fix/mailingAddresses/[[...contactId]]	195.4 KB	+3.51 KB
/accountLists/[accountListId]/tools/fix/sendNewsletter/[[...contactId]]	120.72 KB	+3.5 KB
/accountLists/[accountListId]/tools/import/csv	110.25 KB	+3.5 KB
/accountLists/[accountListId]/tools/import/google	159.67 KB	+3.5 KB
/accountLists/[accountListId]/tools/import/tnt	153.31 KB	+3.5 KB

Dynamic import	Size (gzipped)	Diff
../src/components/Contacts/ContactFlow/DynamicContactFlow.tsx -> ./ContactFlow	64.22 KB	-3.42 KB
../src/components/Contacts/ContactsList/DynamicContactsList.tsx -> ./ContactsList	41.4 KB	-3.42 KB
../src/components/Contacts/ContactsRightPanel/DynamicContactsRightPanel.tsx -> ./ContactsRightPanel	129.38 KB	-3.41 KB
../src/components/Shared/Filters/DynamicFilterPanel.tsx -> ./FilterPanel	104.75 KB	-3.42 KB
../src/components/Tool/Appeal/Flow/DynamicContactFlow.tsx -> ./ContactFlow	64.22 KB	-3.42 KB
../src/components/Tool/Appeal/List/ContactsList/DynamicContactsList.tsx -> ./ContactsList	41.4 KB	-3.42 KB

[canac]

Thanks for working on this!

When I have PRs without a Jira ticket that are based on HelpScout tickets, I think it can be helpful to put the HelpScout link(s) in the PR description so that if we ever need the context for the change it's linked to the user's bug report or feature request.

[canac]

How about removing the string concatenation and after the last else if doing

if (firstName) {
  greeting += ` ${firstName}.`
}

Also, this seems good for now, but if find any more bugs like this, we should probably look into tweaking i18n's interpolation settings.

[caleballdrin]

I'm sure there are many more bugs because of the interpolation settings. My work around in the past has been to use a component where I can set interpolation: { escapeValue: false },

[canac]

What do you think about this tweak?

Suggested change

	? t('Search subject, tags, contact name, comments')
	: t('Search name, phone, email, partner #')
	? t('Search by subject, tags, contact name, or comments')
	: t('Search by name, phone, email, or partner #')

[canac]

✅