Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOS apple-app-site-association name change #1123

Merged
merged 1 commit into from
Oct 10, 2024
Merged

IOS apple-app-site-association name change #1123

merged 1 commit into from
Oct 10, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Oct 9, 2024

Description

Changed the name of the .well-known/apple-app-site-association.json to .well-known/apple-app-site-association to match Apple's naming convention.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz assigned canac and unassigned canac Oct 9, 2024
@dr-bizz dr-bizz requested a review from canac October 9, 2024 14:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 4cced29

No significant changes found

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Oct 9, 2024

No longer required! Doing a redirect as Apple will not pick up file without.json

@dr-bizz dr-bizz closed this Oct 9, 2024
@dr-bizz dr-bizz removed the request for review from canac October 9, 2024 14:48
@canac canac deleted the fix-apple-app-site-association branch October 9, 2024 14:50
@dr-bizz dr-bizz restored the fix-apple-app-site-association branch October 10, 2024 19:51
@dr-bizz dr-bizz reopened this Oct 10, 2024
@dr-bizz
Copy link
Contributor Author

dr-bizz commented Oct 10, 2024

Re-opening as we will try to see if we can achieve it without the .json

@dr-bizz dr-bizz requested a review from levieggertcru October 10, 2024 20:05
@dr-bizz dr-bizz requested a review from caleballdrin October 10, 2024 20:36
@dr-bizz dr-bizz merged commit d7328ba into main Oct 10, 2024
34 checks passed
@dr-bizz dr-bizz deleted the fix-apple-app-site-association branch October 10, 2024 20:44
dr-bizz added a commit that referenced this pull request Oct 10, 2024
@dr-bizz
Revert "Change name to match apples naming convention (#1123)"
3185707 
This reverts commit d7328ba.
@dr-bizz dr-bizz mentioned this pull request Oct 10, 2024
Merged
dr-bizz added a commit that referenced this pull request Oct 10, 2024
@dr-bizz
Revert "Change name to match apples naming convention (#1123)" (#1130)
d41c1e6 
This reverts commit d7328ba.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levieggertcru levieggertcru levieggertcru approved these changes

@caleballdrin caleballdrin caleballdrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dr-bizz @caleballdrin @levieggertcru @canac