Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8322] Update translations #1132

Merged
merged 3 commits into from
Oct 14, 2024
Merged

[MPDX-8322] Update translations #1132

merged 3 commits into from
Oct 14, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 11, 2024

Description

  • Update translation files
  • Sort translation files so that future diffs will be easier to read

MPDX-8322

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac requested a review from dr-bizz October 11, 2024 20:06
@canac canac self-assigned this Oct 11, 2024
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 4a2ca6b

No significant changes found

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we cost just under 300 translations. was that expected?

We lost words like Reminders.

@canac
Copy link
Contributor Author

canac commented Oct 14, 2024

It looks like we cost just under 300 translations. was that expected?

@dr-bizz Where are you getting the number 300 from? git diff main --stat -- public/locales/en/translation.json says we removed 15 labels and added 39. All the changes to public/locales/en/translation.json look correct.

@dr-bizz
Copy link
Contributor

dr-bizz commented Oct 14, 2024

@dr-bizz Where are you getting the number 300 from? git diff main --stat -- public/locales/en/translation.json says we removed 15 labels and added 39. All the changes to public/locales/en/translation.json look correct.

I'm getting the number 300 from the number of lines that have been removed.

@dr-bizz dr-bizz self-requested a review October 14, 2024 14:34
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this as I don't want to block you.

@canac canac merged commit 0faf3f3 into main Oct 14, 2024
17 checks passed
@canac canac deleted the 8322-update-translations branch October 14, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants