Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing nonNull items as they are causing errors when they are null … #1135

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Oct 14, 2024

Description

I removed the nonNull items from GraphQL as some items are null for some users, which causes the page to error and not render the page.

It now seems to work on local.

Helpscout Tix: https://secure.helpscout.net/conversation/2732656504/1242288?folderId=7296147

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Oct 14, 2024
@dr-bizz dr-bizz requested a review from caleballdrin October 14, 2024 21:00
Copy link
Contributor

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 2b6212e

No significant changes found

Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This is also blocking me from being able to push code because of the ts errors.

@dr-bizz dr-bizz merged commit 708ad91 into main Oct 14, 2024
18 of 19 checks passed
@dr-bizz dr-bizz deleted the remove-nonNull-items-on-RC-report branch October 14, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants