Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect-to-RC-when-switch-profiles #1141

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Oct 17, 2024

Description

In this PR, I fix serval bugs and improve the codebase.

Fixes:

Fixed bug when you switch your account on the Summary or Transaction RC pages and receive a error message. Now when you switch, it now redirects you back to the main RC page.

Fixed URL sending user to the entries page. (Simple rename of url)

Improvements

I update the RC pages so they use 3 seperate pages instead of one catch all page. - This should help to prevent unwanted rerenders.

Since we only wanted the transactions page to use context, I had to alter components that are used on the Summary or accounts page to not use context. - This is where a lot of the changes come in.

FYI, I have merged in my recent Tests and changes which caused a lot of merge conflicts, and I had to alter some code.

Please explain a bullet-point summary of the changes.
List any PRs that this PR is dependent on and any Jira tickets that this PR is related to.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Bundle sizes [mpdx-react]

Compared against 482f8f3

Route Size (gzipped) Diff
/accountLists/[accountListId]/contacts/[[...contactId]] 111.04 KB +1.5 KB
/accountLists/[accountListId]/contacts/flows/setup 185.89 KB +1.47 KB
/accountLists/[accountListId]/reports/donations/[[...contactId]] 348.99 KB +1.48 KB
/accountLists/[accountListId]/reports/financialAccounts 255.6 KB added
/accountLists/[accountListId]/reports/financialAccounts/[financialAccountId] 122.08 KB added
/accountLists/[accountListId]/reports/financialAccounts/[financialAccountId]/entries 295.88 KB added
/accountLists/[accountListId]/reports/partnerCurrency/[[...contactId]] 137.77 KB +1.48 KB
/accountLists/[accountListId]/reports/partnerGivingAnalysis/[[...contactId]] 137.1 KB +1.48 KB
/accountLists/[accountListId]/reports/salaryCurrency/[[...contactId]] 137.76 KB +1.48 KB
/accountLists/[accountListId]/tasks/[[...contactId]] 141.44 KB +1.48 KB
/accountLists/[accountListId]/tools 147.29 KB +1.48 KB
/accountLists/[accountListId]/tools/appeals 187.74 KB +1.39 KB
/accountLists/[accountListId]/tools/appeals/appeal/[[...appealId]] 220.65 KB +1.39 KB
/accountLists/[accountListId]/tools/fix/commitmentInfo/[[...contactId]] 251.03 KB +1.57 KB
/accountLists/[accountListId]/tools/fix/emailAddresses/[[...contactId]] 167.64 KB +1.56 KB
/accountLists/[accountListId]/tools/fix/mailingAddresses/[[...contactId]] 125.62 KB +1.56 KB
/accountLists/[accountListId]/tools/fix/phoneNumbers/[[...contactId]] 148.88 KB +1.57 KB
/accountLists/[accountListId]/tools/fix/sendNewsletter/[[...contactId]] 122.66 KB +1.56 KB
/accountLists/[accountListId]/tools/import/csv 112.16 KB +1.55 KB
/accountLists/[accountListId]/tools/import/google 161.59 KB +1.57 KB
/accountLists/[accountListId]/tools/import/tnt 155.15 KB +1.48 KB
/accountLists/[accountListId]/tools/merge/contacts/[[...contactId]] 124.9 KB +1.57 KB
/accountLists/[accountListId]/tools/merge/people/[[...contactId]] 124.19 KB +1.57 KB
/accountLists/[accountListId]/reports/financialAccounts/[[...financialAccount]] no change removed
Dynamic import Size (gzipped) Diff
../src/components/Contacts/MassActions/Merge/DynamicMassActionsMergeModal.tsx -> ./MassActionsMergeModal 13.01 KB +8.5 KB
../src/components/Tool/Appeal/Modals/AddExcludedContactModal/DynamicAddExcludedContactModal.tsx -> ./AddExcludedContactModal 16.74 KB +8.5 KB
../src/components/Reports/FinancialAccountsReport/AccountSummary/DynamicAccountSummary.tsx -> ./AccountSummary no change removed
../src/components/Reports/FinancialAccountsReport/AccountTransactions/DynamicAccountTransactions.tsx -> ./AccountTransactions no change removed
../src/components/Reports/FinancialAccountsReport/FinancialAccounts/DynamicFinancialAccounts.tsx -> ./FinancialAccounts no change removed

@dr-bizz dr-bizz requested a review from canac October 17, 2024 14:59
@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Oct 17, 2024
Copy link
Contributor

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is really good! I briefly tested each of the pages, and they still seem to be working well.

@dr-bizz dr-bizz enabled auto-merge October 17, 2024 20:51
@dr-bizz dr-bizz merged commit b4ece21 into main Oct 17, 2024
17 checks passed
@dr-bizz dr-bizz deleted the redirect-to-RC-when-switch-profiles branch October 17, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants