-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect-to-RC-when-switch-profiles #1141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… needs context uses it to prevent rerenders on the other pages.
Bundle sizes [mpdx-react]Compared against 482f8f3
|
dr-bizz
added
the
Preview Environment
Add this label to create an Amplify Preview
label
Oct 17, 2024
Preview branch generated at https://redirect-to-RC-when-switch-profiles.d3dytjb8adxkk5.amplifyapp.com |
canac
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is really good! I briefly tested each of the pages, and they still seem to be working well.
pages/accountLists/[accountListId]/reports/financialAccounts/[financialAccountId]/Wrapper.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I fix serval bugs and improve the codebase.
Fixes:
Fixed bug when you switch your account on the Summary or Transaction RC pages and receive a error message. Now when you switch, it now redirects you back to the main RC page.
Fixed URL sending user to the entries page. (Simple rename of url)
Improvements
I update the RC pages so they use 3 seperate pages instead of one catch all page. - This should help to prevent unwanted rerenders.
Since we only wanted the transactions page to use context, I had to alter components that are used on the Summary or accounts page to not use context. - This is where a lot of the changes come in.
FYI, I have merged in my recent Tests and changes which caused a lot of merge conflicts, and I had to alter some code.
Please explain a bullet-point summary of the changes.
List any PRs that this PR is dependent on and any Jira tickets that this PR is related to.
Checklist: