Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Improve coaching monthly commitment graph #803

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 30, 2023

Changes:

  • Reverse data to read from left to right
  • Localize committed and received labels
  • Make the chart a stacked bar chart

To test, login as apps+mpdx@cru.org and go to http://localhost:3000/accountLists/308c5567-a0b6-49f6-922e-f0c338e170ca/coaching/08bb09d1-3b62-4690-9596-b625b8af4750.

* Reverse data to read from left to right
* Localize committed and received labels
* Make the chart a stacked bar chart
@canac canac added the On Staging Will be merged to the staging branch by Github Actions label Oct 30, 2023
@canac canac requested review from caleballdrin and dr-bizz October 30, 2023 17:01
@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-803.d3dytjb8adxkk5.amplifyapp.com

@canac
Copy link
Contributor Author

canac commented Oct 30, 2023

Tested in staging ✅

Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@canac canac merged commit 6bd22b9 into main Oct 30, 2023
15 checks passed
@canac canac deleted the coaching-graph branch October 30, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants