Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-7678 - GraphQL error when filtering by completed tasks #805

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Nov 1, 2023

Description

When on the tasks page, click on a Contact, then switch Tasks tab. An error occurs regarding contacts filters not being able to filter on Tasks filters.

This is caused as we're using Context to share contacts' global state across all of the components of the contact. We really need to spend a day or 2 switching Context to Redux as the contact data is used throughout the app and not just on contacts components. I'll create a task for this.

Changes

  • Fixed the error by not passing down Tasks filters to the contact context. We don't need the activeFilters or starredFilters, as we're just showing the contact drawer.

@dr-bizz dr-bizz requested review from canac and caleballdrin November 1, 2023 12:37
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-805.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it out locally and it works. Great work figuring out a temporary fix for this! I agree that the contact detail context needs some attention when we can carve out some time to refactor it.

@dr-bizz dr-bizz added the On Staging Will be merged to the staging branch by Github Actions label Nov 1, 2023
@dr-bizz dr-bizz merged commit 5d09cf6 into main Nov 1, 2023
15 checks passed
@dr-bizz dr-bizz deleted the MPDX-7678-tasks-filter branch November 1, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants