Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding default Pull request template #807

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Nov 1, 2023

Description

Adding PR template for future PRs.
I also know that I'm breaking the first rule by not adding a Jira ticket in the title since this change is so small... What a rebel.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz requested a review from canac November 1, 2023 21:00
@dr-bizz dr-bizz added the On Staging Will be merged to the staging branch by Github Actions label Nov 1, 2023
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-807.d3dytjb8adxkk5.amplifyapp.com

## Checklist:

- [ ] I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
- [ ] I have applied the appropriate labels
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a good place to mention to new contributors that they can add the "On Staging" label to get the branch automatically merged into staging?

@dr-bizz dr-bizz merged commit 2d3274f into main Nov 2, 2023
15 checks passed
@dr-bizz dr-bizz deleted the adding-pull-request-template branch November 2, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants