Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-7727 Add organization to add donation modal #831

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Dec 1, 2023

Description

https://jira.cru.org/browse/MPDX-7727
In the helpscout ticket mentioned in the title, the user has multiple orgs that he receives donations with and he says that the add donation modal in angular has a way to choose a specific org, while in react, it doesn't.  I don't see this org selection option on the add donation modal in my angular version of MPDX to provide a screenshot, but I'm also not associated with multiple orgs.

The user also requested the ability to choose a date by just picking a date rather than needing to hit "Ok" when not on mobile.

Changes I made

  • The autocomplete was only showing the designation accounts from the first organization. Show all designation accounts in all organizations by flattening designationAccounts
  • Changing MobileDatePicker to DatePicker so it will automatically show different date pickers on Web vs Mobile.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Dec 1, 2023
@caleballdrin caleballdrin requested a review from dr-bizz December 1, 2023 17:24
@caleballdrin caleballdrin added the On Staging Will be merged to the staging branch by Github Actions label Dec 1, 2023
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-831.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Please can you ask Scott to QA this before we put t live.

@caleballdrin caleballdrin merged commit d82cd14 into main Dec 14, 2023
15 checks passed
@caleballdrin caleballdrin deleted the new-donation branch December 14, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants