Fixing multiple speed issues with Graph QL and SSR #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne on load and the RouterGuard ensures the page is redirected to /login if authenicated.
dr-bizz
added
the
On Staging
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As GraphQL batches queries together. Slower queries slow down the rest. I created a way where we can choose if a query gets batched or not.
The GraphQL client server is running with the fetch policy "Cache and Network", this is so it checks the cache first to see if there's data but also sends a network request to see if there is updated data. If I switched this to "Cache first", it loads in the cache first, and if found, it doesn't do a network refetch. However, it can cause issues as data may have been updated and the user won't see it.
Also updated the Dashboard to no longer be SSR. This saves some time when loading the page. The reason it was SSR in the first place was to make the animations look great, but it isn't needed, and I added some impersonator logic, which I don't think we need. I need to double-check this on staging.
Checklist: