Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No-Jira] Show all financial accounts on Responsibility Centers Page #847

Merged
merged 6 commits into from
Jan 4, 2024
Merged

[No-Jira] Show all financial accounts on Responsibility Centers Page #847

merged 6 commits into from
Jan 4, 2024

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Jan 2, 2024 •
edited
Loading

Description

https://secure.helpscout.net/conversation/2457168102/1071165/
Change the graphql request limit so that all financial accounts are shown on the Responsibilities Center page.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin added the On Staging Will be merged to the staging branch by Github Actions label Jan 2, 2024
@caleballdrin caleballdrin requested a review from canac January 2, 2024 21:29
@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-847.d3dytjb8adxkk5.amplifyapp.com

canac
canac reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully my change fixes the tests 🤞

src/lib/client.ts Outdated Show resolved Hide resolved
@caleballdrin
Copy link
Contributor Author

caleballdrin commented Jan 4, 2024 •
edited
Loading

@canac Do you have any ideas on seeing what the accounts look like on staging? The test MPDX account doesn't have any accounts on the Responsibility Center report.

canac
canac approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉

@caleballdrin caleballdrin merged commit a97f7c4 into main Jan 4, 2024
14 of 15 checks passed
@caleballdrin caleballdrin deleted the fix-rc branch January 4, 2024 21:29
@caleballdrin caleballdrin self-assigned this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

Assignees

@caleballdrin caleballdrin

Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleballdrin @canac