Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint Fix: Fix for new Phone numbers schema change #861

Merged
merged 12 commits into from
Jan 25, 2024
Merged

Lint Fix: Fix for new Phone numbers schema change #861

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f5367b2
fixing lint issue
dr-bizz Jan 18, 2024
11382af
adding preventative measures to ensure there isn't a error. Need to t…
dr-bizz Jan 18, 2024
1a48c52
Fixing phone fields and UX since we now allow null for phone numbers
dr-bizz Jan 19, 2024
b988429
Adding gqlMock and changing how we validate deleting number so we no …
dr-bizz Jan 22, 2024
8a2825b
Switching to use gqlMock instead of a const
dr-bizz Jan 22, 2024
da9925f
JS styling fixes
dr-bizz Jan 23, 2024
6756772
Removed schema error andreplaced with normal error
dr-bizz Jan 24, 2024
b561dc2
Adding testing for Phone validation
dr-bizz Jan 24, 2024
933a3d7
More test coverage and changing filter to some for simplify code
dr-bizz Jan 24, 2024
2476813
Ensure phone numbers are rendered correctly
dr-bizz Jan 24, 2024
5c3bf69
Ensure phone numbers and the primary number are rendered correctly
dr-bizz Jan 25, 2024
98f0a72
Merge branch 'main' into fix-phone-numbers
dr-bizz Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...onents/Contacts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@
return {
id: phoneNumber.id,
primary: phoneNumber.primary,
number: phoneNumber.number,
number: phoneNumber?.number,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will help. I believe it's number that will be null, not phoneNumber. And if phoneNumber is null, all the other property access calls with throw an exception too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about this one, I added it just in case. I want to test with a Null number. I'll do that tomorrow

historic: phoneNumber.historic,
location: phoneNumber.location,
destroy: false,
Expand Down Expand Up @@ -482,9 +482,9 @@

interface attributes {
id: string;
greeting: any;

Check warning on line 485 in src/components/Contacts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonModal.tsx

View workflow job for this annotation

GitHub Actions / eslint 

Unexpected any. Specify a different type
envelopeGreeting: any;

Check warning on line 486 in src/components/Contacts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonModal.tsx

View workflow job for this annotation

GitHub Actions / eslint 

Unexpected any. Specify a different type
name: any;

Check warning on line 487 in src/components/Contacts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonModal.tsx

View workflow job for this annotation

GitHub Actions / eslint 

Unexpected any. Specify a different type
primaryPersonId?: string;
}
const attributes: attributes = {
Expand Down
2 changes: 1 addition & 1 deletion src/components/Tool/FixPhoneNumbers/FixPhoneNumbers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ const FixPhoneNumbers: React.FC<Props> = ({ accountListId }: Props) => {
primary: phoneNumber.primary,
updatedAt: phoneNumber.updatedAt,
source: phoneNumber.source,
number: phoneNumber.number,
number: phoneNumber.number || '',
}),
),
toDelete: [],
Expand Down
Loading