Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Fix codegen retry action #881

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[no-Jira] Fix codegen retry action #881

merged 1 commit into from
Feb 26, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Feb 23, 2024

Description

Fix codegen retry added in #880. As mentioned in this issue, the action will succeed unless the last command in a multiline command fails. This can cause the action to succeed even when the yarn gql step fails, as seen in this action run.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the On Staging Will be merged to the staging branch by Github Actions label Feb 23, 2024
@canac canac requested a review from dr-bizz February 23, 2024 19:41
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-881.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix it.

@canac canac merged commit 4ca6c76 into main Feb 26, 2024
18 checks passed
@canac canac deleted the retry-codegen branch February 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants